[Project] aCis - Interlude

[SweeTs]

Changeset 288

NPCs template refactor part III, misc

NPCs refactor
   - handle final stats calculation from template stats (formula : base * carac bonus * levelmodifier).
   - fix pets evasion/accuracy

AIs
   - "FleeNpc" is moved to "group" folder, and is renamed "FleeingNPCs".
   - split L2AttackableAIScript content into 2 layers : L2AttackableAIScript and AbstractNpcAI.
      - "group" and "individual" AIs extends AbstractNpcAI. That layer got methods dedicated to such AIs.
      - L2AttackableAIScript becomes a basic script, stored in "group".
      - That split prepares the eventuality of listeners system addition.
   - random cleanup (SummonMinions, Orfen, etc).
   - Addition of BrokenLabyrinth script : http://boards.lineage2.com/showthread.php?t=146273
   - Addition of PlainsOfDion script.
   
Misc
   - Addition of _scriptValue system. Drop of hasSpoken system.
   - AI timeout is setted back on 120sec (after L2OFF IL check).
   - critical with barehands is correctly calculated (after L2OFF IL check : use DEX mod).
   
Notes
   - _scriptValue is unique to a spawn, you have to care about multiple scripts editing behavior of a npc.

[SweeTs]

Changeset 290

Summons, misc

Summons
   - fix stats (they finally had to use funcs).
   - fix base critical on summons (40 for all).

Misc
   - fix an issue involving null objects on pet pickup action.
   - minions follow distance is made using collision radius of both minion and leader (avoid weird 500 distance on rb minion follow).
   - drop few methods on instances which are only knownlist stuff.
   - fix skills 118 and 163 (nerf mages nudists ;p).
   - fix order of tradelists' content.
   - isSeedable() implementation.


Sources of rev 280 can be found here :

Click me

[SweeTs]

Changeset 291

AIs, misc

AIs
   - addition of the cursed ToIVortex script.
   - addition of FirstClassChange script (mix of 4-6 scripts), ty to Fernandopm . Compared to his version :
      - addition of ids 32097 and 32098 (+56 missing HTMs).
      - cleanup the advEvent (a single array is kept instead of making *8 map checks).
      - Pa'agrio and others typos.
   - edit ShadowWeapon ids ; it takes directly ids from scripts FirstClassChange && SecondClassChange (as second script isn't made yet, the array is still local).
   - fix Barakiel minions AI.
   
Misc
   - fix subclass crap (Maximilion/Jurek and others Mystic/Priest).
   - fix dozen of typos on village_master HTMs, and harmonize links position (L2J team was dyslexic back in 2007...).
      - all first masters got a link for shadow weapon coupons exchange.
      - all second masters got a link for subclass. First masters who had one is dropped.
   - addition of //show_scripts npcId : allow to see events affecting the given template.
   - fix L2EffectZone concurrent exception. As L2EffectZone are always supposed to have a skillid, initialize the map directly in order to avoid null checks.
   - after a check on L2OFF, bring the speed modifier when you run in water from 0.5 to 0.41.
   - revert canceling target fix but keep the cleanup (no whining anymore).
   - fix an issue on summon window stats about runspeed (it was only visual). In same time, getMoveSpeed() becomes an int.
   
Note : I tested 6 IDs out of 20+, and obviously hasn't the will to test/fix eventual typos on the 800+ HTMs, if there is issues, you know where to complain.

[SweeTs]

Changeset 292

Misc
   - [L2J 5772] Moving effect flags out of CharEffectList into L2EffectFlag enum.
   - cancels enchant process while moving.
   - equipped shadow weapons are now correctly handled at player login/logout (armors as weapons). Tasks can be canceled now (before it was running even unequipped).
   - 40% of Inventory file has been splitted into listeners.
   - fix //show_characters.
   - fix PaganTeleporter. Statue don't react to faded mark, triol's mirror hasn't any checks and the zone with faded mark is implemented.
   - added back handwritten ids for zone system. Dropped zone name (no use).
   - reintroduction of ZONE_SCRIPT for... scripts. Use that XML for your custom scripts.
   - drop merchant_areas_list SQL (unused).
   - random cleanup.
   
Notes
   - zones ids are still dynamically generated, but it will be replaced by a written id (if found). Scripts use ids 100000+.

[SweeTs]

Changeset 293

Misc
   - Numerous fixes on UseItem, mostly related to messages and readability. Unhardcode Calculator itemhandler.
   - ChristmasTree itemhandler wasn't loaded.
   - effects affecting players are restored before Enterworld access (fix HP/MP/CP issues at restart)
   - critical rate of summons is corrected.
   - fix a concurrent exception on PcFreight as object access was followed by list clear inside the loop (? lol). _depositedFreight is also initialized with player instance and never null anymore (drop null checks).
   - pets don't share anymore master reuse. Master don't receive anymore infos regarding pet uses (notably, icons-related stuff). Ty CreamCracker for report.
   - fix pet pickup message (on multiple items).
   - 6 items are now considered as potions (etcitem type is potion), ty Root for report.
   
PS : as items reuse system isn't really developed on IL chronicle (potions only ?), I decided pets timestamps won't be saved in db.

[SweeTs]

Changeset 294

Scripts, Misc

Scripts
   - Cleanup Core.
   - addition of Q373.
   - addition of StakatoNest AI. The whole behavior is postIL, but there are some evidences that AI was in preparation (perhaps fully working ? Who knows, it's the sort of definitively lost data) in IL time.

Misc
   - Fix previous commit regarding skill bar at restart (nice catch Trance).
   - Drop GlobalVariable system, as we got ServerVariables system.
   - Cleanup Quest (avoid to return L2ZoneType and others misc).
   - fix few max quests number checks (25 quests max according client ingame quest panel)
   - drop a double QuestList packet send at quest aborting.
   - cleanup of show_skilllist (use a simple array of L2Skill instead of a Map, no iterator, StringBuffer > StringBuilder).
   - drop null checks on NPC skills templates (never null).
   - fix summons skill level at skill launch (was generated from summon level...). The data was ok, but the level was overriden for godamn known reason.
   - the generic addfuncs are initialized before skills addfuncs (there were no problems, it's just more logical to load regular funcs then skills funcs).
   - gates level mod is reinitialized to L2Character one (potential problem about evasion), add 2 funcs for gates instead of overriden pdef/mdef (Ty masssttteeerrr ).

[SweeTs]

Changeset 295

Sailren, MovieMaker, Zone system && GrandBossManager, misc

Sailren AI
   - A wild Sailren appeared ! Ty UnAfraid for the L2OFF script (leeched cinematic, oust location, exit gk locations, and inactive timer duration).
   - addition of the blank npc 32110 (for the animation), one L2BossZone, change of type for L2GrandBoss, one line added in grandboss_data.sql and edition of GrandBossTeleporters script to handle Shilen Stone / Teleport Cube behaviors.

MovieMaker enhancements
   - you can now see all parameters of sequences on main panel.
   - if you haven't a target, the movie takes you as target.
   - addition of "Back" buttons on Edit and Add HTMs, returning to main panel.
   
Zone system && GrandBossManager
   - GrandBossManager singleton system is dropped (use static approach).
   - Cleanup and few method renames.
   - Few fixes :
      - lists and maps from L2BossZone can't be null anymore (drop involved checks) and use concurrent versions.
      - GMs are now registered in _playersAllowed list - as regular players - if they used the "legit" way. They still have priviledges to teleport on such area and not being bothered by restriction.
      - avoid to add a zone if it was already existing (just a security check, as List allows doublons).
   - Reintroduction on ids on L2BossZone zones, in order to correctly load/save allowed players (cause a problem notably if you add/remove zones meanwhile).
   - L2ZoneType variables concerning zones children are moved in zones children :
      - affectedRace > L2MotherTreeZone.
      - affectedLvlMin / targetClass > L2EffectZone.
      - Following parameters are dropped : affectedClassId, affectedClassType, affectedLvlMax.
      - drop of internal flag _checkAffected, as isAffected() uses now inheritance.
   - All null checks concerning L2BossZone zones on scripts are dropped (as those scripts can't, anyway, work without those zones...).

Misc
   - Addition of door HPs view (happens in peace time or for siege defenders). isEnemy() is dropped and replaced by isAutoAttackable() for doors HP view.
   - All configs related to GBs are renamed. Hardcoded safeties are dropped, so don't edit configs when drunk.
   - fix clan ranks for heroes and nobles + L2ClanMember cleanup, ty BaT for report.
   - all variables on individual AIs are organized as following : zone, private static final, public static final, public.
   
PS : while L2ScriptZone are using 10XXXX ids, L2BossZone will use 11XXXX ones. Remember about it while adding custom zones !

[SweeTs]

Changeset 296

Antharas, RBs timers, Misc

Antharas
   - addition of death cinematic (ty UnAfraid for the script).
   - Antharas use his skills following L2OFF script. And yes, the Rnd.get() fuckfest is retail-like.

RBs timers
   - fix GBs/RBs timers to follow L2OFF values. The biggest change is regular bosses going from 12-36h to 12-60h (36 +- 24) && Zaken/Sailren timers.
   - random timer is modified to handle hours by hours, not ms by ms (* 3600000 is made after the Rnd is selected).
   - random timer on GBs is supposed to be +-, not only + (edition of all GBs AI scripts).
   - drop of RaidMinRespawnMultiplier and RaidMaxRespawnMultiplier configs. I don't like them. Don't ask.
   
Misc
   - addition of ZoneId (exemple : L2Character.ZONE_PVP > ZoneId.PVP).
   - fix arenas XP loss, ty Root for report. You still loss XP inside arenas if killed by anything except playable (avoid RB exploits).
   - you don't lose XP while in siege, if you were involved by the siege (either playable or siege NPCs).
   - fix new clan member "rank" (you are registered in main clan, not on 5th grade). Ty SweeTs.
   - fix an invalid pvpflag scenario (summoner is out of the arena, but summon/pet is in : attacking the summon/pet makes you purple).
   - reorganization of L2PcInstance isAutoAttackable(), which also fix 1 issue about clan member check (the clan member check was made on attacker's objectId, but attacker can be the summon...).
   - bring isInsideZone in L2Object, allowing to drop all casts.
   - addition of isInArena(), as it's often used (checks if a player is in a PVP zone but not in a SIEGE zone).
   - getWantsPeace() > wantsPeace(), modified for a boolean rather than int.
   
Notes :
   - getRespawnMinDelay() and getRespawnMaxDelay() are "overriden" on L2RaidBoss spawn to be used as fixed and random timers => (getRespawnMinDelay() + Rnd.get(-getRespawnMaxDelay(), getRespawnMaxDelay())) * 3600000.
   - isAutoAttackable is to test.

[SweeTs]

Changeset 297

Quests, Misc

Quests
   - addition of Q344, Q660 - ty Junior.
   - fix Q374/Q375, ty Tommy.

Misc
   - drop setIsFlying() and setIsRiding() method, using inheritance.
   - fix few skills : 6 summon skills (npcIds were messed up), missing nextActionAttack - ty Tommy.
   - fix toggle stopping movement action and next action stopping current action - ty xblx.
   - rename AI_INTENTION_X to X, and harmonize uses for CtrlIntention.X.
   - avoid to send a FOLLOW intention when clicking on yourself.

[SweeTs]

Changeset 298

Quests, Misc

Quests
   - addition of Q421, Q643.
   - FairyTree AI is melted with Q421 : killed tree spawns numerous ghosts, and ghosts speak when tree is under attack.
   - add 3 HTMs related to Q348, edit qItems to be qItems.
   
Knownlist
   - knownlist is reworked ; drop iterators, drop _knownPlayers and _knownRelation maps.
   - cleanup KnownListUpdateTaskManager (drop _failedRegions, merge cases), ty xblx.
   
Misc
   - npcs.xml is edited for Fairy Trees case : they become L2Monster, can't move, and got 3 minions.
   - fix ss/bss consumption for pets and summons, ty Tommy. No more sanity check.
   - fix Corpse Burst (power table) and Arrest(should aggro) skills, ty xblx.
   - fix StunSelf effect, ty Myazz.
   - revert part of rev 274 in order to fix short animations when you cast a skill (ex : raging force).
   - random misc

[SweeTs]

Changeset 299

Quests/AI, Knownlists, Misc

Quests
   - addition of Q218, Q223 (added Road Collector / Harpy Matriarch AI), Q348 (ty equip, fernandopm, Tommy).
   - Baium cleanup regarding statue animation, drop of _waker.

Knownlists
   - cleanup KnownListUpdate : merging checks, merging method updateRegion with the task, do an action only if given object is an L2Character, checks moved out of for loops and "final"-ized, fix an issue of timer.
   - _knownList is moved from L2Object to L2Character. Items and L2Static aren't associated anymore to a knownlist object.
   
Misc
   - fix a typo in getClosestTownName() method (S*c*huttgart).

[SweeTs]

Changeset 300

Scripts, Misc

Scripts
   - addition of Q222, Q232 (ty equip, Junior).
   - cleanup numerous quests (getQuestItemsCount > hasQuestItems, drop of "exitQuest(true)" on STARTED cases, misc). Need to do more, I was lazy to re-read all godamn quests...
   - fix DoctorChaos respawn time (for regular RB time).

Misc
   - fix revive animation, drop of _isPendingRevive and associated getter/setter - ty Kingzor / xblx.
   - cleanup ItemSkills && ScrollOfRessurection itemhandlers (fix SoR consumption, made on skill call not on item call) - ty Kingzor / xblx.
   - fix esc, target is supposed to be kept if you were casting a skill (but a second press on esc cancels the target)- ty dEvilKinG for report.
   - drop GM bypasses regarding inventory capacity (avoid to be filled at 105/80).
   - use of hasPet() when possible. hasPet() check doesn't check if != null (as instanceof is doing it).
   - fix Olympiads zone ids 7 && 8, and move all spawn points farer to center (ty Rainbow Dash).
   - fix the alert on console regarding Shadow Sense (ty Rainbow Dash).
   
To be perfectly honest I was lazy those days and some things haven't be tested, notably olys zones (if they're wrong, complain to Hasha :p) and quests changes (that's just code changes, shouldn't alter the logic).


Changeset 301

Olympiads, Quests, Misc

Olympiads - ty Hasha.
   - fix visual bug regarding participant HP bars.
   - fix visual bug regarding participants buffs bar refresh (for spectators).
   - wait time setted by default to 30sec.
   - rework spectators system.
   - drop ExOlympiadUserInfoSpectator packet (not used).
   - add 2 configs (AltOlyWaitBattle && AltOlyWaitEnd).
   - random cleanup.

Quests
   - cleanup numerous quests (notably Q163, Q166, Q171, Q294, Q296).
   
Misc
   - cleanup ClanTable - ty Hasha.
      - avoid to use getter/setter inside the file.
      - scheduleRemoveClan parameter is changed for L2Clan not int (avoid to read 4 times the Map to find the L2Clan).
   - cleanup L2Clan
      - avoid to use getter/setter inside the file.
      - Integer parameter > int.
      - Drop of L2Clan version for setEnemyClan / setAttackerClan. Integer survivor > int.
      - Edit deleteEnemyClan(L2Clan) / deleteAttackerClan(L2Clan) parameters from L2Clan to int (clanId).
      - simplify few methods (notably ".contains" which implicitely returns a boolean).
      - getAllSkills() is edited for getClanSkills().
      - drop of _skillList, 2 removeSkill(int/L2Skill) and getSkills() methods (L2JIL unused) - ty Hasha.
      - drop of addClanMember(L2ClanMember) method (private, 3 uses, 1 line method).
      - getOnlineMembers(int) loses his parameter.
      - addSkillEffects(), updateClanScoreInDB() methods are dropped.
      - rework setReputationScore(int) method in order to avoid to create 3 times (!) clan members list, and regenerate getClanSkills() for every member. Use of Math.min/max.
      - setHasHideout() / setHasCastle() renamed for setHideout() / setCastle(). Variables are also renamed.
   - L2PcInstance
      - the Map storing subclasses is initialized with instance itself, and final.
   - sorted maps for subclasses, macros and skill lists - ty xblx, Trance.
   - fix beginner shortcuts (self heal was overidden sit icon) - ty Kingzor.
   - fix one systemMessage, and 3 others (not used yet, so not visible) - ty Hasha.
   - drop of L2TIntObjectHashMap (only one use before, not used anymore).
   - fix an issue regarding clan skills give back once Olympiads are done, if clan reputation is <= 0.
   - fix top/bottom ; getting one OR the other doesn't mean you got both anymore (1 && 0 || 0 && 1 = 0, not 1). Ty Hasha.
   - Skills (need to do a lot more about skills...)
      - fix Focus Attack (set to 1, not add 1).


Rev 290 can be found here :

Click me

[SweeTs]

Changeset 302

Quests, Misc

Quests
   - addition of Q212, Q365, Q383

Misc
   - fix a double animation on custom L2ClassMaster. Ty Kingzor.
   - revert changes made on ExHeroList (not buggy anymore, but still not retail).
   - L2Clan (again)
      - drop addSkill(L2Skill) method - unused.
      - addNewSkill(L2Skill)
         - manages to regroup 3 others packet sending in an existing getOnlineMembers() loop (avoid creation of 3 clan members lists per skill addition).
         - avoid to send skill refresh packet if the clan skill doesn't match your rights.
         - the message saying you earned a clan skill is now broadcasted to all clan members, rather than only clan leader (create some stuff to clan chat about...)
      - setReputation
         - refresh members skill list (when an update is needed).
         - fixes an error introduced in previous rev (rep points update has to be made even if an update isn't needed).

[Innactive]

As i saw yesterday the project isn't more public they change it to Private. Don't know if this will help.

[SweeTs]

As i saw yesterday the project isn't more public they change it to Private. Don't know if this will help.

Say what? It's semi-private. All info is in 1st post I update it whenever it's needed


Also, the progress is a bit stopped 2 months already, cuz Tryskell play too much online games.. but there is nothing to worry

[SweeTs]

Changeset 303

Headquarters, Four sepulchers, Misc

Headquarters
   - HPs are now properly setted, but during flag spawn (as we refactored npcs.xml, the NPC got 40HPs following L2OFF).
   - HPs is currently doubled when Noblesse HQ version is used (and not, as regular L2J, damages mitigation).
   - L2SiegeFlagInstance cleanup.
   - drop of SiegeFlagStatus.
   - show skill cast error message even out of castle area.

Four sepulchers
   - Q620 rework (HTMs renamed, simplified structure).
   - Wigoth doesn't burn a Used Grave Pass anymore.
   - You can choose your recipe correctly.

Misc
   - [301] fix an Integer > int issue : if parameter is an int, .remove( method of ArrayList removes by index, not by given object.
   - [301] revert an experimental code for ss/bss effect, which has been commited by negligeance (and was buggy).
   - fix a log warning related to a SystemMessage.
   - slight edit in targetReconsider() method in order mobs don't attack doors or invisible GMs (+ a lot more checks). Don't make anymore movement checks for "regular" targetReconsider (reserved for skills checks).
   - edit StatsSet logs, in order it gives info related to the missing stat.
   - L2CharTemplate/L2NpcTemplate got more values setted by default (if you have to create a custom template, you got minimum infos to care about).
   - drop unrelated/inheritated stats from doors templates (as it inherits from L2CharTemplate, not L2NpcTemplate, no need of exp/sp/rHand/lHand/etc).
   - add pdef/mdef of doors on admin shift click panel (more fashion).
   - fix an error in calcSiegeRegenModifer() formula (wasn't taking custom in consideration). Move method from double to boolean.
   - fix a concurrent issue on L2CommandChannel + basic cleanup.

[SweeTs]

Changeset 304

Karma, Misc

Karma
   - [L2J 6074] added retail karma drop/gain system.
   - KARMA_PLAYER_CAN_BE_KILLED_IN_PZ does only what the name suggests. Drop redundant checks on isInsidePeaceZone().
   - don't clean karma on death if ALT_GAME_DELEVEL is setted to False (as karma drop is related to xp loss upon death).
   - don't earn a PK point on summons/pets kills (but still earn karma).
   - drop 4 configs related to Karma calculation method.
   - restoring exp (via BSoR / res skills / GM commands add_xp) don't clean karma. Ty Zerador for report.

Misc
   - L2CastleTeleporterInstance cleanup, also fix an HTM typo. Ty sahar.
   - [L2J 6070] cleanup calculateRewards(). Multiple fixes and performances tweaks.
      - doesn't create an empty map if aggrolist was empty.
      - avoid to calculate xp/sp gain if attacker is dead.
      - limit the list of rewarders to L2PcInstance (avoid all checks regarding summons).
      - fix issue regarding summons/summoner damages (one was overwriting the other, now it cumulates).
      - calculations are based on total damage made, not on maxHP of the monster.
   - don't earn a PvP point on summons/pets kills.
   - cleanup L2Party (internal vars uses rather than getters/setters, party broadcast setted to 12s instead of 10sec).
   - drop useless itemhandler ChristmasTree.
   - beast ss/sps are desactivated on summon death + cleanup poor overidden use on doDie() (L2Summon, L2PetInstance, L2SummonInstance).

[SweeTs]

Changeset 305

Skills, Misc

Skills
   - fix Polearm Accuracy (422), ty djdiablo for the fix.
   - fix treasure keys, based on previous SoR rework. You will stop to harass me with this at least, for Elmoreden's love.
      - drop DeluxeKeys skillhandler, add Keys itemhandler. DELUXE_KEY_UNLOCK is considered as a Dummy skill.
      - you can't consume a key on dead chests nor mimics ones (invalid target message).
      - regular keys are debugged : can't use on doors, and it uses the deluxe handler. Add the 60% luck on Chests.java script.
      - ONLY regular/deluxe keys for treasure chests are debugged. Others (pagan keys ?) would eventually be fixed when I will know their uses.

Misc
   - summons don't intention-stuck anymore if they're broken during a skill cast (they will either follow you back or continue attack).
   - fix Anakim/Lilith "out" teleporters. Fix teleporters spawns, and players spawns to be centered on the "tile".
   - avoid to refresh twice overload and penalty checks at character restore.
   - fix package sell mode (must stay checked if previously checked), ty sahar for report.
   - added retail penalty system, ty devilking for patch.
   - edit config NoQuests for NoScripts, and make a use of it, ty Root for the idea.
   - peace zone stuff :
      - drop the different implementations of isInsidePeaceZone(), keeping one. As that method includes allowPeaceAttack() check, drop external checks.
      - summons can't force attack anymore players on peace zone. Instead, it will follow target. Drop also the message, as there isn't on L2OFF.
      
TODO
   - missing SAs / dual passive skills drop/add on refreshExpertisePenalty().

[SweeTs]

Also, new spawnlist (l2off generated) under test-mode.

More here:

http://acis.i-live.eu/index.php?topic=4516.0

Big thanks to mcbigmac

[SweeTs]

Changeset 306

Quests, MapRegionTable, Misc (known in future generations as "Hasha commit" or " you Bingo quests")

Quests
   - addition of Q381, Q382, Q384 (ty Tommy, roko91, Hasha for sexy help)

MapRegionTable (ty Hasha)
   - merge TownManager and MapRegionTable.
   - fix an issue with regions, where dying from Valakas's Lair would lead to teleport back to TI Island (out of region array).
   - multiple code improvements and data update.
   
Misc
   - cleanup items consumption messages (destroyItemByItemId() got it embedded), ty Hasha.
   - addition of scrambleString(string).